“What have you done?” and “What did you do?” are both correct, but they are used in different situations.
“What have you done?” uses the present perfect tense and usually asks about a past action that has a connection to the present or whose result matters now. “What did you do?”
uses the simple past tense and usually asks about a completed action in the past, especially when the past time is known or understood.
For example, if you walk into a room and see a broken window, you might ask, “What have you done?”
because you are reacting to the present result. If you ask someone about their activities yesterday, you would say, “What did you do yesterday?” because the action belongs to a finished past time.
Understanding this difference will help you choose the correct tense naturally in conversations, questions, storytelling, and everyday English.
Quick Answer
“What have you done?” asks about a past action connected to the present, often focusing on its result or consequence. “What did you do?” asks about a completed past action, usually at a definite or understood past time. Use have you done for present relevance and did you do for finished past events.
Why Do People Confuse “What Have You Done?” and “What Did You Do?”
The confusion comes from the fact that both questions ask about something that happened before now.
The important difference is how the speaker views the past action.
- What have you done? → The action has a connection with the present.
- What did you do? → The speaker is asking about a completed past event.
Compare:
What have you done? The kitchen is covered in flour!
The speaker can see the present result.
What did you do yesterday?
The speaker is asking about an activity at a finished time in the past.
The key grammar difference is the tense:
- have/has + past participle → present perfect
- did + base verb → simple past
First Word: “What Have You Done?”
“What have you done?” is the present perfect form.
The structure is:
What + have/has + subject + past participle?
For example:
- What have you done?
- What has she done?
- What have they done?
The past participle of do is done, so we say:
What have you done?
not:
What have you did? ✗
When does “What have you done?” mean?
It usually asks about an action whose result, consequence, or relevance is important now.
For example:
What have you done to your hair?
The speaker can see the person’s hair now.
What have you done? The computer isn’t working!
The speaker is concerned about a present problem caused by a past action.
It can also express surprise, shock, anger, or concern depending on tone.
What have you done?!
The grammar is neutral, but the emotional meaning comes from the situation and the speaker’s voice.
Second Word: “What Did You Do?”
“What did you do?” uses the simple past tense.
The structure is:
What + did + subject + base verb?
For example:
- What did you do?
- What did she do?
- What did they do?
Notice that after did, we use the base form of the verb:
What did you do? ✓
Not:
What did you did? ✗
When does “What did you do?” mean?
It usually asks about a completed action or event in the past.
For example:
What did you do last weekend?
The weekend is finished.
What did you do after work yesterday?
The speaker is asking about a specific past period.
The simple past is especially natural when the time is stated or clearly understood:
- yesterday
- last night
- last week
- two days ago
- in 2024
- when you were a child
What Have You Done vs. What Did You Do: Comparison Table
| Expression | Tense | Main focus | Typical time | Example |
|---|---|---|---|---|
| What have you done? | Present perfect | Present result or relevance | Unspecified past | What have you done to the car? |
| What did you do? | Simple past | Completed past action | Definite/finished past time | What did you do yesterday? |
| What have you done today? | Present perfect | Activities within a time period connected to now | Today | What have you done today? |
| What did you do yesterday? | Simple past | Completed past activities | Yesterday | What did you do yesterday? |
When Should You Use “What Have You Done?”
Use “What have you done?” when the exact past time is not important and the action has a connection with the present.
Use it when:
- You can see a present result.
- You are reacting to something that has just happened.
- The consequences are important now.
- The exact time of the action is unknown or unimportant.
- You are asking about actions during a period that is still continuing.
Example
What have you done to the door?
Maybe the door is damaged now. The speaker cares about its current condition.
You can also use it for a continuing time period:
What have you done today?
If today is still happening, the present perfect can describe things completed so far today.
When Should You Use “What Did You Do?”
Use “What did you do?” when you are asking about a finished past event or period.
Use it when:
- The action happened at a finished time.
- The time is mentioned.
- The time is understood from context.
- You are telling or discussing a past story.
- The present result is not the main focus.
Example
What did you do last night?
“Last night” is a finished period, so the simple past is appropriate.
14+ Examples of “What Have You Done?” and “What Did You Do?”
1. Present result
What have you done to my phone?
The speaker sees that something is wrong with the phone now.
2. Finished past activity
What did you do with my phone yesterday?
The question focuses on a past activity.
3. Recent action
What have you done? The baby is crying!
The speaker is reacting to a present situation.
4. Definite past time
What did you do after school yesterday?
The action belongs to yesterday.
5. Today’s activities
What have you done today?
Today is still in progress.
6. Yesterday’s activities
What did you do yesterday?
Yesterday has finished.
7. Present consequence
What have you done to the computer? It won’t start.
The computer’s current condition matters.
8. Past event
What did you do when you arrived at the office?
The speaker is asking about a past event.
9. Emotional reaction
What have you done?!
The speaker is reacting strongly to something that has happened.
10. Asking about a completed project
What have you done with the report?
The speaker wants to know its current status or what has happened to it.
11. Asking about a past job
What did you do at your previous company?
The speaker is asking about past employment.
12. Present situation
What have you done to the kitchen? It looks completely different!
The present appearance is important.
13. Past vacation
What did you do during your vacation last year?
The vacation is a completed past period.
14. Time period continuing until now
What have you done so far this morning?
The morning is being viewed as a period connected to the present.
Common Mistakes
Mistake 1: Using “did” with “done”
Do not say:
What did you done? ✗
After did, use the base verb:
What did you do? ✓
Mistake 2: Using “have” with “did”
Do not say:
What have you did? ✗
Use the past participle:
What have you done? ✓
Mistake 3: Using present perfect with a finished past time
In standard English, avoid:
What have you done yesterday? ✗
Use:
What did you do yesterday? ✓
“Yesterday” is a finished past time, so the simple past is normally used.
Mistake 4: Thinking “have you done” always means something recent
The present perfect does not necessarily mean “just now.” It can refer to an earlier action when the present connection is important.
What have you done with the documents?
The action could have happened earlier; the speaker wants to know the current situation.
Mistake 5: Thinking “did” always needs a stated time
A specific past-time expression is not required.
For example:
What did you do?
This can be perfectly natural when both speakers understand that the question refers to a particular past event.
Memory Trick
Use this simple rule:
Have you done? → Think “What is the situation now?”
Did you do? → Think “What happened then?”
For example:
What have you done to the car?
→ What is the car like now?
What did you do to the car yesterday?
→ What action did you take yesterday?
Another useful shortcut is:
Present connection = have done
Finished past time = did do
American vs. British English
The basic grammar rule is the same in American and British English: both varieties use the present perfect and simple past to express different relationships with past events.
However, there can be differences in everyday usage, especially with expressions such as just, already, yet, ever, and recently. British English generally uses the present perfect more often in some situations where American English may use the simple past.
For example, British English commonly favors:
Have you eaten yet?
American English can also use this form, but in casual American speech you may hear:
Did you eat yet?
This does not change the basic distinction between “What have you done?” and “What did you do?”. Context and meaning remain the most important factors.
Similar Words and Expressions
“What have you been doing?”
This uses the present perfect continuous and often asks about activities continuing over a period of time.
What have you been doing all morning?
It can suggest that the speaker is interested in the activity or process.
“What were you doing?”
This uses the past continuous.
What were you doing at 8 p.m.?
It focuses on an activity that was in progress at a particular past moment.
“What did you do?”
This focuses on a completed past action or event.
What did you do after dinner?
“What have you done so far?”
This asks about completed actions within a period that is still connected to the present.
What have you done so far today?
“What happened?”
This is broader and asks about an event or situation.
What happened to your phone?
Final Verdict
Use “What have you done?” when a past action has a connection with the present, especially when you are interested in its result, consequence, or current situation.
Use “What did you do?” when asking about a completed past action, particularly when the time is finished or clearly located in the past.
The easiest way to remember the difference is:
What have you done? = What is the result now?
What did you do? = What happened in the past?
FAQs
1. What is the difference between “What have you done?” and “What did you do?”
“What have you done?” uses the present perfect and focuses on a past action connected to the present. “What did you do?” uses the simple past and focuses on a completed past action.
2. Is “What have you done yesterday?” correct?
Normally, no. Use “What did you do yesterday?” because “yesterday” refers to a finished past time.
3. Is “What did you do?” grammatically correct?
Yes. “What did you do?” is the correct simple past question. After did, use the base verb do, not did or done.
4. Why do people say “What have you done?” when they are angry?
The expression itself is not necessarily angry. However, it is often used when someone sees an unexpected or serious present result, so the situation and tone can make it sound shocked, worried, or angry.
5. Can “What have you done?” refer to something that happened a long time ago?
Yes. The present perfect does not always mean that something happened recently. It can refer to an earlier action when its result or relevance continues into the present.
6. Should I say “What have you done today?” or “What did you do today?”
If today is still continuing, “What have you done today?” is a common choice because the time period is still connected to the present. “What did you do today?” is also heard, especially in American English and depending on context.
7. What is the difference between “What have you been doing?” and “What did you do?”
“What have you been doing?” focuses on activities over a period leading up to now. “What did you do?” focuses on completed past actions.
8. Is “What have you done?” present perfect?
Yes. It follows the present perfect structure:
have + past participle
In “What have you done?”, “have” is the auxiliary verb and “done” is the past participle of do.
Remember This
What have you done? → Present connection or result.
What did you do? → Finished past action.
Have + done → Present perfect.
Did + do → Simple past.
Yesterday / last week / two years ago → Usually simple past.
Today / so far / recently → Often present perfect when the period or situation remains connected to now.
Conclusion
The difference between “What have you done?” and “What did you do?” is mainly about how the speaker connects the past action to the present. The present perfect, “have done,” highlights a present result, consequence, or continuing relevance. The simple past, “did do,” treats the action as a completed event in the past.
When you are talking about a finished time such as yesterday, last night, or two years ago, choose “What did you do?” When the important point is what has happened and how it matters now, choose “What have you done?” Once you learn to focus on the time and present connection, the difference becomes much easier.
